Added multiarch build support for Teleport#17597
Merged
fheinecke merged 65 commits intoOct 31, 2022
Merged
Conversation
Contributor
|
@fheinecke - this PR is large and will require admin approval to merge. Consider breaking it up into a series smaller changes. |
Contributor
Author
|
Note to reviewers: I'll be deploying a series of commits to test this PR in Drone itself. For now please ignore any commits after d288768. This also removes the following pipelines:
The following pipelines have been manually edited (not in dronegen):
|
fheinecke
force-pushed
the
fred/multiarch-teleport-actual-container-images
branch
2 times, most recently
from
6c9f4d9 to
d288768
Compare
Contributor
Author
|
|
Contributor
Author
|
@wadells @r0mant @logand22 This is ready for a (hopefully) final review. All testing changes have been reverted. See PR main comment for a link to drone test runs. Images are also available for testing here:
|
r0mant
dismissed
wadells’s stale review
Walt is on leave and his feedback was implemented.
fheinecke
added a commit
that referenced
this pull request
Nov 7, 2022
fheinecke
added a commit
that referenced
this pull request
Nov 8, 2022
fheinecke
added a commit
that referenced
this pull request
Nov 8, 2022
fheinecke
added a commit
that referenced
this pull request
Nov 8, 2022
fheinecke
added a commit
that referenced
this pull request
Nov 14, 2022
* Added multiarch build support for teleport-operator (#16688) * Added multiarch build support for Teleport (#17597) * Fix cron jobs updating teleport operator on v9 * Linter fix * Disabled promote prerelease check * Linter fix * Resigned drone.yml after merge * Removed accidentally added pipline due to branch merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part two of a series of PRs updating drone/dronegen to support multiarch builds.
The primary purpose of this PR is to add multiarch Teleport container images. This includes amd64, arm, and arm64 images under the
$MAJOR_VERSIONtag on each release.Due to the complexity of how we handle building and publishing container images this PR includes a number of other changes:
.drone.ymlAfter this PR is merged I will open a final PR for Teleport Lab.
Related PR:
Test runs prior to merging PR: